feat: support for nested write-only arguments + write-only arguments for `google_monitoring_notification_channel` #15538

ramonvermeulen · 2025-10-29T17:30:06Z

This PR introduces support for nested write-only fields and adds write-only arguments for the google_monitoring_notification_channel resource.

Closing: hashicorp/terraform-provider-google#21855

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

monitoring: add write-only variants (`auth_token_wo`, `password_wo`, `service_key_wo`) for `google_monitoring_notification_channel`

ramonvermeulen · 2025-10-29T17:37:53Z

When I do a local build, the ExactlyOneOf seems to have all the correct fields now:

ExactlyOneOf: []string{"sensitive_labels.0.auth_token", "sensitive_labels.0.password", "sensitive_labels.0.service_key", "sensitive_labels.0.auth_token_wo", "sensitive_labels.0.password_wo", "sensitive_labels.0.service_key_wo"},

@melinath

Let's discuss this feature further on this draft, I would like to validate with you if this aligns a bit with the original idea you had in mind for this feature.

github-actions · 2025-10-29T18:04:48Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

melinath

yeah this looks like what I was imagining. It looks like the downstream generation worked fine / came out as expected, even for the case where multiple write only fields are added to the same constraint group 👍

Should be good to go once we have tests for the new fields.

ramonvermeulen · 2025-11-10T12:01:57Z

Should be good to go once we have tests for the new fields.

Great, I will try to add these tests today!

Do we also want to add some documentation about this logic somewhere? At least I can imagine without context reading this code for the first time might be a bit confusing, e.g. "why the ... do they apply this pointer logic?".

On the other hand it is also not that big of a change.

EDIT:
While adding the tests in c93f109 I also noticed the flatteners and expanders do not get generated, most likely because it is a "nested" field. I remember we never implemented the full support for nested fields (yet).

I will see what I can do to make it work. I think it is a unique case in general, because this use-case uses a custom encoder and url_param_only: true at https://github.com/ramonvermeulen/magic-modules/blob/03b0d07a70f6937bdbece2ecd47a367d449a809e/mmv1/products/monitoring/NotificationChannel.yaml#L104 which doesn't generate an expander for sensitive_labels to begin with.

…to nested fields and `url_param_only: true`)

ramonvermeulen · 2025-11-12T14:03:12Z

I will see what I can do to make it work.

I think I managed to address most of this in 8a48fca and ac2487d, unfortunately it is still quite some custom code, but that is also because sensitiveLabels seems to be quite a unique case. Can you retrigger the CI?

Tests on latest commit:

➜ make testacc TEST=./google/services/monitoring TESTARGS='-run=TestAccMonitoringNotificationChannel_'
sh -c "'/Users/ramon/go/src/github.com/hashicorp/terraform-provider-google/scripts/gofmtcheck.sh'"
==> Checking that code complies with gofmt requirements...
go vet
TF_ACC_REFRESH_AFTER_APPLY=1 TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/monitoring -v -run=TestAccMonitoringNotificationChannel_ -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccMonitoringNotificationChannel_notificationChannelBasicExample
=== PAUSE TestAccMonitoringNotificationChannel_notificationChannelBasicExample
=== RUN   TestAccMonitoringNotificationChannel_update
=== PAUSE TestAccMonitoringNotificationChannel_update
=== RUN   TestAccMonitoringNotificationChannel_updateLabels_slack
    resource_monitoring_notification_channel_test.go:57:
--- SKIP: TestAccMonitoringNotificationChannel_updateLabels_slack (0.00s)
=== RUN   TestAccMonitoringNotificationChannel_updateLabels
=== PAUSE TestAccMonitoringNotificationChannel_updateLabels
=== RUN   TestAccMonitoringNotificationChannel_updateSensitiveLabels_slack
    resource_monitoring_notification_channel_test.go:107:
--- SKIP: TestAccMonitoringNotificationChannel_updateSensitiveLabels_slack (0.00s)
=== RUN   TestAccMonitoringNotificationChannel_updateSensitiveLabels
=== PAUSE TestAccMonitoringNotificationChannel_updateSensitiveLabels
=== RUN   TestAccMonitoringNotificationChannel_updateSensitiveLabelsWo
=== PAUSE TestAccMonitoringNotificationChannel_updateSensitiveLabelsWo
=== RUN   TestAccMonitoringNotificationChannel_updateSensitiveLabelsWo_slack
    resource_monitoring_notification_channel_test.go:216:
--- SKIP: TestAccMonitoringNotificationChannel_updateSensitiveLabelsWo_slack (0.00s)
=== CONT  TestAccMonitoringNotificationChannel_notificationChannelBasicExample
=== CONT  TestAccMonitoringNotificationChannel_updateSensitiveLabels
=== CONT  TestAccMonitoringNotificationChannel_updateSensitiveLabelsWo
=== CONT  TestAccMonitoringNotificationChannel_updateLabels
=== CONT  TestAccMonitoringNotificationChannel_update
--- PASS: TestAccMonitoringNotificationChannel_notificationChannelBasicExample (6.64s)
--- PASS: TestAccMonitoringNotificationChannel_updateLabels (8.15s)
--- PASS: TestAccMonitoringNotificationChannel_updateSensitiveLabels (10.79s)
--- PASS: TestAccMonitoringNotificationChannel_updateSensitiveLabelsWo (14.25s)
--- PASS: TestAccMonitoringNotificationChannel_update (14.40s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/monitoring       15.182s

I only think the documentation for write-only arguments is still not generated fully correct. I think it makes sense to wait a little bit with that before #15385 is merged?

We most likely need to add some changes to this file to enable support for the nested write-only docs: https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/templates/terraform/nested_property_documentation.html.markdown.tmpl.

ramonvermeulen · 2026-01-20T14:59:14Z

@melinath

I applied some of the feedback, but not everything. I rely heavily on at least ensuring the existing acceptance tests keep succeeding with the changes.

─ ~/go/src/github.com/hashicorp/terraform-provider-google main *3 !9                                                                                                                                                 ▼  1.24.5 󰊭 xxxxxx ─╮
╰─❯ make testacc TEST=./google/services/monitoring TESTARGS='-run=TestAccMonitoringNotificationChannel_'                                                                                                                                   ─╯
sh -c "'/Users/ramon/go/src/github.com/hashicorp/terraform-provider-google/scripts/gofmtcheck.sh'"
==> Checking that code complies with gofmt requirements...
go vet
TF_ACC_REFRESH_AFTER_APPLY=1 TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/monitoring -v -run=TestAccMonitoringNotificationChannel_ -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccMonitoringNotificationChannel_notificationChannelBasicExample
=== PAUSE TestAccMonitoringNotificationChannel_notificationChannelBasicExample
=== RUN   TestAccMonitoringNotificationChannel_update
=== PAUSE TestAccMonitoringNotificationChannel_update
=== RUN   TestAccMonitoringNotificationChannel_updateLabels_slack
    resource_monitoring_notification_channel_test.go:57:
--- SKIP: TestAccMonitoringNotificationChannel_updateLabels_slack (0.00s)
=== RUN   TestAccMonitoringNotificationChannel_updateLabels
=== PAUSE TestAccMonitoringNotificationChannel_updateLabels
=== RUN   TestAccMonitoringNotificationChannel_updateSensitiveLabels_slack
    resource_monitoring_notification_channel_test.go:107:
--- SKIP: TestAccMonitoringNotificationChannel_updateSensitiveLabels_slack (0.00s)
=== RUN   TestAccMonitoringNotificationChannel_updateSensitiveLabels
=== PAUSE TestAccMonitoringNotificationChannel_updateSensitiveLabels
=== RUN   TestAccMonitoringNotificationChannel_updateSensitiveLabelsWo
=== PAUSE TestAccMonitoringNotificationChannel_updateSensitiveLabelsWo
=== RUN   TestAccMonitoringNotificationChannel_updateSensitiveLabelsWo_slack
    resource_monitoring_notification_channel_test.go:216:
--- SKIP: TestAccMonitoringNotificationChannel_updateSensitiveLabelsWo_slack (0.00s)
=== CONT  TestAccMonitoringNotificationChannel_notificationChannelBasicExample
=== CONT  TestAccMonitoringNotificationChannel_updateSensitiveLabels
=== CONT  TestAccMonitoringNotificationChannel_updateSensitiveLabelsWo
=== CONT  TestAccMonitoringNotificationChannel_updateLabels
=== CONT  TestAccMonitoringNotificationChannel_update
--- PASS: TestAccMonitoringNotificationChannel_updateSensitiveLabels (9.99s)
--- PASS: TestAccMonitoringNotificationChannel_updateLabels (11.53s)
--- PASS: TestAccMonitoringNotificationChannel_notificationChannelBasicExample (11.75s)
--- PASS: TestAccMonitoringNotificationChannel_update (13.06s)
--- PASS: TestAccMonitoringNotificationChannel_updateSensitiveLabelsWo (18.62s)
PASS
ok      github.com/hashicorp/terraform-provider-google/google/services/monitoring       19.420s

Let's generate a new diff and see what is left to change, at least all acceptance tests succeed on the latest commit.

modular-magician · 2026-01-20T19:17:35Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 522 insertions(+), 35 deletions(-))
google-beta provider: Diff ( 9 files changed, 522 insertions(+), 35 deletions(-))
terraform-google-conversion: Diff ( 7 files changed, 372 insertions(+), 52 deletions(-))

modular-magician · 2026-01-20T21:40:28Z

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccMonitoringNotificationChannel_updateSensitiveLabelsWo_slack

Tests analytics

Total tests: 5933
Passed tests: 5294
Skipped tests: 634
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager__service_perimeter_dry_run_egress_policy

TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy

TestAccComputeNetwork_bgpModeAndMedInteractions

TestAccComputeNetwork_networkBgpStandardModeDeleteMed

TestAccComputeNetwork_networkBgpStandardModeDeleteMedExample

Get to know how VCR tests work

modular-magician · 2026-01-20T21:55:17Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccComputeNetwork_bgpModeAndMedInteractions [Debug log]
TestAccComputeNetwork_networkBgpStandardModeDeleteMed [Debug log]
TestAccComputeNetwork_networkBgpStandardModeDeleteMedExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_level_condition [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

github-actions · 2026-01-21T09:50:00Z

@GoogleCloudPlatform/terraform-team @melinath This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

melinath

responded on the threads above.

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

ramonvermeulen · 2026-01-29T15:13:06Z

responded on the threads above.

I commented on the decoder, I am slightly confused now on how to move forward, especially because it is quite a complex resource. How I understand it is that sensitiveLabels is not a field in the API, so it sort of uses url_param_only in combination with a custom decoder and encoder to trick magic modules in generating a configurable field for it, while under the hood it just writes to labels.

Now with the added write-only variant it even becomes more complex, because the write-only variant must also write to labels under the hood. That is also why I rely so heavily on these acceptance tests succeeding.

ramonvermeulen · 2026-01-29T15:53:54Z

Changed the code a little bit in 5d25a49 to make it ignore_read, but when I remove the decoder logic I still get:

TF_ACC_REFRESH_AFTER_APPLY=1 TF_ACC=1 TF_SCHEMA_PANIC_ON_ERROR=1 go test ./google/services/monitoring -v -run=TestAccMonitoringNotificationChannel_ -timeout 240m -ldflags="-X=github.com/hashicorp/terraform-provider-google/version.ProviderVersion=acc"
=== RUN   TestAccMonitoringNotificationChannel_notificationChannelBasicExample
=== PAUSE TestAccMonitoringNotificationChannel_notificationChannelBasicExample
=== RUN   TestAccMonitoringNotificationChannel_update
=== PAUSE TestAccMonitoringNotificationChannel_update
=== RUN   TestAccMonitoringNotificationChannel_updateLabels_slack
    resource_monitoring_notification_channel_test.go:57:
--- SKIP: TestAccMonitoringNotificationChannel_updateLabels_slack (0.00s)
=== RUN   TestAccMonitoringNotificationChannel_updateLabels
=== PAUSE TestAccMonitoringNotificationChannel_updateLabels
=== RUN   TestAccMonitoringNotificationChannel_updateSensitiveLabels_slack
    resource_monitoring_notification_channel_test.go:107:
--- SKIP: TestAccMonitoringNotificationChannel_updateSensitiveLabels_slack (0.00s)
=== RUN   TestAccMonitoringNotificationChannel_updateSensitiveLabels
=== PAUSE TestAccMonitoringNotificationChannel_updateSensitiveLabels
=== RUN   TestAccMonitoringNotificationChannel_updateSensitiveLabelsWo
=== PAUSE TestAccMonitoringNotificationChannel_updateSensitiveLabelsWo
=== RUN   TestAccMonitoringNotificationChannel_updateSensitiveLabelsWo_slack
    resource_monitoring_notification_channel_test.go:216:
--- SKIP: TestAccMonitoringNotificationChannel_updateSensitiveLabelsWo_slack (0.00s)
=== CONT  TestAccMonitoringNotificationChannel_notificationChannelBasicExample
=== CONT  TestAccMonitoringNotificationChannel_updateSensitiveLabels
=== CONT  TestAccMonitoringNotificationChannel_updateLabels
=== CONT  TestAccMonitoringNotificationChannel_update
=== CONT  TestAccMonitoringNotificationChannel_updateSensitiveLabelsWo
=== NAME  TestAccMonitoringNotificationChannel_updateSensitiveLabels
    resource_monitoring_notification_channel_test.go:132: Step 1/3 error: After applying this test step, the plan was not empty.
        stdout:


        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place

        Terraform will perform the following actions:

          # google_monitoring_notification_channel.basicauth will be updated in-place
          ~ resource "google_monitoring_notification_channel" "basicauth" {
                id                  = "projects/<masked>/notificationChannels/11479684971851401096"
              ~ labels              = {
                  - "password" = "************" -> null
                    # (2 unchanged elements hidden)
                }
                name                = "projects/<masked>/notificationChannels/11479684971851401096"
                # (7 unchanged attributes hidden)

                # (1 unchanged block hidden)
            }

          # google_monitoring_notification_channel.pagerduty will be updated in-place
          ~ resource "google_monitoring_notification_channel" "pagerduty" {
                id                  = "projects/<masked>/notificationChannels/8907246682644664376"
              ~ labels              = {
                  - "service_key" = "************_key" -> null
                }
                name                = "projects/<masked>/notificationChannels/8907246682644664376"
                # (7 unchanged attributes hidden)

                # (1 unchanged block hidden)
            }

        Plan: 0 to add, 2 to change, 0 to destroy.
=== NAME  TestAccMonitoringNotificationChannel_updateSensitiveLabelsWo
    resource_monitoring_notification_channel_test.go:161: Step 1/6 error: After applying this test step, the plan was not empty.
        stdout:


        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place

        Terraform will perform the following actions:

          # google_monitoring_notification_channel.basicauth will be updated in-place
          ~ resource "google_monitoring_notification_channel" "basicauth" {
                id                  = "projects/<masked>/notificationChannels/8739585973205083796"
              ~ labels              = {
                  - "password" = "************" -> null
                    # (2 unchanged elements hidden)
                }
                name                = "projects/<masked>/notificationChannels/8739585973205083796"
                # (7 unchanged attributes hidden)

                # (1 unchanged block hidden)
            }

          # google_monitoring_notification_channel.pagerduty will be updated in-place
          ~ resource "google_monitoring_notification_channel" "pagerduty" {
                id                  = "projects/<masked>/notificationChannels/8907246682644665825"
              ~ labels              = {
                  - "service_key" = "************_key" -> null
                }
                name                = "projects/<masked>/notificationChannels/8907246682644665825"
                # (7 unchanged attributes hidden)

                # (1 unchanged block hidden)
            }

        Plan: 0 to add, 2 to change, 0 to destroy.
--- FAIL: TestAccMonitoringNotificationChannel_updateSensitiveLabels (14.76s)
--- FAIL: TestAccMonitoringNotificationChannel_updateSensitiveLabelsWo (15.66s)
--- PASS: TestAccMonitoringNotificationChannel_notificationChannelBasicExample (15.86s)
--- PASS: TestAccMonitoringNotificationChannel_updateLabels (17.08s)
--- PASS: TestAccMonitoringNotificationChannel_update (21.08s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-google/google/services/monitoring       21.898s
FAIL
make: *** [testacc] Error 1

On test execution, so I kept it for now.

modular-magician · 2026-01-30T23:36:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 9 files changed, 497 insertions(+), 25 deletions(-))
google-beta provider: Diff ( 10 files changed, 498 insertions(+), 33 deletions(-))
terraform-google-conversion: Diff ( 8 files changed, 373 insertions(+), 41 deletions(-))

modular-magician · 2026-01-31T01:49:42Z

Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccMonitoringNotificationChannel_updateSensitiveLabelsWo_slack

Tests analytics

Total tests: 5987
Passed tests: 5351
Skipped tests: 634
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager__service_perimeter_dry_run_egress_policy

TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy

Get to know how VCR tests work

modular-magician · 2026-01-31T02:07:25Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__access_policy_scoped [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Oct 29, 2025

ramonvermeulen force-pushed the f/24327-write-only-pointer-constraint-groups branch from fd2c99f to 0d5ec68 Compare October 29, 2025 17:32

This comment was marked as outdated.

Sign in to view

github-actions bot requested a review from melinath October 29, 2025 18:04

melinath marked this pull request as ready for review October 29, 2025 18:05

This comment was marked as outdated.

Sign in to view

modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/terraform and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Oct 29, 2025

This comment was marked as outdated.

Sign in to view

ramonvermeulen mentioned this pull request Oct 29, 2025

monitoring: add write-only support for notification_channel sensitive_labels #15524

Closed

This comment was marked as outdated.

Sign in to view

melinath requested changes Nov 5, 2025

View reviewed changes

ramonvermeulen added 5 commits November 10, 2025 13:02

feat: initial implementation of the constraint group registry

342bf27

fix: also enable write_only for the service_key

7177185

refactor: slightly simplify implementation

61aa6ea

fix: this branching seems redundant

3d9bf59

fix: format

6cd97e8

github-actions bot requested a review from melinath November 10, 2025 12:03

test: added tests for write-only labels (encountered some issues due …

c93f109

…to nested fields and `url_param_only: true`)

ramonvermeulen force-pushed the f/24327-write-only-pointer-constraint-groups branch from 03b0d07 to c93f109 Compare November 10, 2025 15:07

ramonvermeulen added 2 commits November 12, 2025 14:56

fix: apply write-only templating logic for nested fields

8a48fca

fix: use write-only generation instead of the custom implementation

ac2487d

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 14, 2026

This comment was marked as outdated.

Sign in to view

ramonvermeulen force-pushed the f/24327-write-only-pointer-constraint-groups branch from e1eb47d to 6bb8dba Compare January 20, 2026 10:45

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 20, 2026

ramonvermeulen force-pushed the f/24327-write-only-pointer-constraint-groups branch from 2fa8999 to bc39ae4 Compare January 20, 2026 12:14

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 20, 2026

melinath mentioned this pull request Jan 24, 2026

Removed ReadProperties method #16219

Merged

melinath requested changes Jan 24, 2026

View reviewed changes

modular-magician mentioned this pull request Jan 28, 2026

Removed ReadProperties method GoogleCloudPlatform/terraform-google-conversion#5065

Merged

ramonvermeulen and others added 4 commits January 29, 2026 11:14

Merge branch 'main' into f/24327-write-only-pointer-constraint-groups

7784bfd

fix: solved the markdown rendering

bc7d6ff

fix: apply quick suggestions from code review @melinath

a779460

Co-authored-by: Stephen Lewis (Burrows) <[email protected]>

feat: additional changes to clean-up the decoder

dde31a9

github-actions bot requested a review from melinath January 29, 2026 15:14

fix: make sensitiveLabels ignore_read and make encoder more specific

5d25a49

ramonvermeulen force-pushed the f/24327-write-only-pointer-constraint-groups branch from bc39ae4 to 5d25a49 Compare January 29, 2026 15:49

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 29, 2026

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 30, 2026

feat: support for nested write-only arguments + write-only arguments for google_monitoring_notification_channel #15538

Are you sure you want to change the base?

feat: support for nested write-only arguments + write-only arguments for google_monitoring_notification_channel #15538

Uh oh!

Conversation

ramonvermeulen commented Oct 29, 2025 • edited by melinath Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ramonvermeulen commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

github-actions bot commented Oct 29, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

melinath left a comment

Choose a reason for hiding this comment

Uh oh!

ramonvermeulen commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ramonvermeulen commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

ramonvermeulen commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Jan 20, 2026

Diff report

Uh oh!

modular-magician commented Jan 20, 2026

Non-exercised tests

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 20, 2026

Uh oh!

github-actions bot commented Jan 21, 2026

Uh oh!

melinath left a comment

Choose a reason for hiding this comment

Uh oh!

ramonvermeulen commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ramonvermeulen commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Jan 30, 2026

Diff report

Uh oh!

modular-magician commented Jan 31, 2026

Non-exercised tests

Tests analytics

Action taken

Uh oh!

modular-magician commented Jan 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: support for nested write-only arguments + write-only arguments for `google_monitoring_notification_channel` #15538

feat: support for nested write-only arguments + write-only arguments for `google_monitoring_notification_channel` #15538

ramonvermeulen commented Oct 29, 2025 •

edited by melinath

Loading

ramonvermeulen commented Oct 29, 2025 •

edited

Loading

ramonvermeulen commented Nov 10, 2025 •

edited

Loading

ramonvermeulen commented Nov 12, 2025 •

edited

Loading

ramonvermeulen commented Jan 20, 2026 •

edited

Loading

ramonvermeulen commented Jan 29, 2026 •

edited

Loading

ramonvermeulen commented Jan 29, 2026 •

edited

Loading